Prepare for docker builds in CI #842
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdupress
force-pushed
the
docker-builds-in-ci
branch
from
fe424ef to
a6bb879
Compare
fdupress
force-pushed
the
docker-builds-in-ci
branch
2 times, most recently
from
14847f6 to
7d980bd
Compare
Member
Author
|
Right—putting this one on pause. It is silly to run this as a matrix when the base is build in all 3 jobs, but can't be shared. I need to rethink this—including whether we want to publish the base and build images. On the plus side, the build is working. |
fdupress
force-pushed
the
docker-builds-in-ci
branch
from
7d980bd to
66611b8
Compare
fdupress
force-pushed
the
docker-builds-in-ci
branch
from
66611b8 to
b219d50
Compare
Member
Author
|
Notes to self on debugging the pipeline. All images got built. base-box got pushed successfully (and is in the container repository), but the push for build-box failed despite successful authentication. The failure happened shortly after 15 minutes. I may need to split the job, add dependencies between jobs, and make sure we cache as much of the work as possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lays the groundwork for being able to generate dockerfiles in CI. I added a workflow_dispatch trigger so docker containers corresponding to specific branches (other than
latest, and release tags) can also be produced. Hopefully, I can use it to test the change.At the moment, the script tries to push the container to the GHCR—this hopefully should fail without first putting effort into setting credentials and a secure environment. (But who knows?)
latestmay be renamed tostableas part of (or before) this merge.